Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing docs for new features #1071

Merged
merged 23 commits into from
Apr 23, 2022
Merged

Added missing docs for new features #1071

merged 23 commits into from
Apr 23, 2022

Conversation

jbednar
Copy link
Member

@jbednar jbednar commented Apr 15, 2022

Fixes #968.

  • Moved spreading to the Transformation pipeline section for clarity.
  • Added rescale_discrete_levels example.
  • Documented 2D categorical spreading.
  • Documented 3D non-categorical aggregation.
  • Added antialiasing example to 3_Timeseries.ipynb .
  • Added polygons docs based on Jon Mease's example notebook.

@jbednar jbednar marked this pull request as draft April 15, 2022 16:57
@jbednar jbednar added this to the 0.14.0 milestone Apr 15, 2022
@jbednar
Copy link
Member Author

jbednar commented Apr 20, 2022

@o-smirnov , if you get a chance, it would be great if you could review the category_binning and category_modulo docs finally added in this PR, adapted from #927 (comment) . Your original example was clearer, but I didn't want to use a different sample dataset, so I adapted it to the synthetic data already in use. Hopefully you won't spot any errors in my descriptions or examples!

@o-smirnov
Copy link
Contributor

Thanks @jbednar, working my way through it, could I have a couple more days please?

@jbednar
Copy link
Member Author

jbednar commented Apr 21, 2022

Thanks, @o-smirnov ! We'll be working on other things for at least the next day or so, but as soon as the last glitches are addressed (mostly CI) we'll be releasing. There isn't much material in here about the category stuff, so it shouldn't take long, but in any case if we have to release without you, we'll just fix it afterwards!

@jbednar jbednar marked this pull request as ready for review April 23, 2022 05:33
@jbednar
Copy link
Member Author

jbednar commented Apr 23, 2022

Windows 3.7 builds are failing due to an issue with Fiona (pulled in by geopandas), but I'll go ahead and merge since that's not specifically related to this PR and I want to build the docs.

@jbednar jbednar merged commit 6e5ebd2 into master Apr 23, 2022
@jbednar jbednar deleted the moredocs branch April 23, 2022 20:00
@o-smirnov
Copy link
Contributor

@jbednar a bit late, but I had a look at the docs and it all looks fine to me!

@jbednar
Copy link
Member Author

jbednar commented Apr 25, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing docs
3 participants