-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing docs for new features #1071
Conversation
@o-smirnov , if you get a chance, it would be great if you could review the category_binning and category_modulo docs finally added in this PR, adapted from #927 (comment) . Your original example was clearer, but I didn't want to use a different sample dataset, so I adapted it to the synthetic data already in use. Hopefully you won't spot any errors in my descriptions or examples! |
Thanks @jbednar, working my way through it, could I have a couple more days please? |
Thanks, @o-smirnov ! We'll be working on other things for at least the next day or so, but as soon as the last glitches are addressed (mostly CI) we'll be releasing. There isn't much material in here about the category stuff, so it shouldn't take long, but in any case if we have to release without you, we'll just fix it afterwards! |
…dded rescale_discrete_levels example. Documented 2D categorical spreading.
Windows 3.7 builds are failing due to an issue with Fiona (pulled in by geopandas), but I'll go ahead and merge since that's not specifically related to this PR and I want to build the docs. |
@jbednar a bit late, but I had a look at the docs and it all looks fine to me! |
Thanks! |
Fixes #968.