-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ufunc 'over' not supported for the input types in 7_Networks.ipynb #792
Comments
I had the same over problem with xarray 0.9.6 and pandas 0.23, which are quite old by now, so it's a mystery. |
Reproducer:
|
(but |
It also works if you remove |
The only thing I can think of is maybe the issue is with versions of numba. |
That's a good suggestion, thanks. numba is 0.45.1 in my main environment, but I see the same symptoms with 0.39.0. Datashader's setup.py suggests that the original requirement was 0.37.0, but I wasn't able to test 0.37 or 0.38 due to conda failing to solve with my existing environment in that case. I can probably get it to install in a separate environment, but it doesn't look promising as an explanation... |
It doesn't appear to be an issue with an external library changing, but with the Datashader code itself. The notebook and the reproducer work fine with the last release (Datashader 0.7.0, revision 1b9f300), and as recently as commit ff89603 on August 23. The first commit where the reproducer breaks is e42694b, which corresponds to merging pull request #779. #779 does include changes to the construction of categorical xarray objects, and specifically appears to change from having coordinates as lists:
to coordinates as ordered dictionaries, which presumably provides names to the coordinates:
Maybe xarray is balking at merging the categorical and non categorical Image objects because of some declared difference in the names of the coordinates, even though the coordinates themselves are the same? @jonmmease , can you explain what this change was for, or if you can think of something else that changed in this PR that could be causing this problem? |
This change (from list to |
With current master and xarray 0.11.3 or 0.13 and pandas 0.25.1, the http://datashader.org/user_guide/7_Networks.html#Graphs-with-categories section of the user guide is failing with the error:
Presumably that code used to work, since the page looks fine on the website. Python's complaining about overlaying the node and edge plots in this case, even though overlaying those same types of plots in other cells above and below works fine using the same code. Plus if I hack graphplot to overlay just the nodes on themselves or just the edges on themselves, the overlay works, suggesting that the edges and nodes in this case are individually fine but end up as incompatible types of object that can't be overlaid with over. Yet the two plots appear to have the same type (<class 'datashader.transfer_functions.Image'>) and dtype (uint32).
I'll try to see when this problem started, but it has the same behavior on xarray 0.11.3 and 0.13, so if it's due to a change in xarray it would presumably be from an older version.
The text was updated successfully, but these errors were encountered: