Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbednar @philippjfr I could use some feedback on this PR. I believe pytest was only run on Linux 3.7. I've opened it up to all platforms/versions so its possible that some of these are known issues that I should avoid.
Current status:
Python 3.6 - PASS
Python 3.7 - PASS
Python 2.7, Ubuntu
Some failures looking for DISPLAY env var:
Invalid DISPLAY variable
https://github.com/kcpevey/colorcet/pull/1/checks?check_run_id=2042433951#step:9:489 Which I could set... but if you look at the code block where the failure is, its thinking that the ubuntu 2.7 build is X11 and its part of a qt5 backend. Which just seems wrong is several different ways. Should I just set the variable it wants or dig into why its getting there in the first place?
I see this failure on all 2.7 architectures
https://github.com/kcpevey/colorcet/pull/1/checks?check_run_id=2042433951#step:9:502
Seems like the codebase is not actually supported on 2.7? It would be an easy fix to swap these around though. Should add that in as well?
For python 3.5 I'm seeing this:
I did some initial googling about this, but I haven't worked out a solution (or what the problem is, actually).