Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new color sets with new aliases #26

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Apr 2, 2019

Closes #24

This PR only adds colormaps and aliases those that are the same or that have a new style name. This means that there are several cmaps with 3 aliases and 2 cmaps with 4. But I still think it will be an easier user experience.

@jsignell jsignell self-assigned this Apr 2, 2019
@jsignell jsignell requested a review from jbednar April 2, 2019 15:44
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. Happy to merge when tests pass.

@jsignell
Copy link
Member Author

jsignell commented Apr 2, 2019

Great! I'll merge and release once they pass.

@jsignell
Copy link
Member Author

jsignell commented Apr 2, 2019

Probably should bump to 2.0.0, but I'll do a dev release first

@jsignell jsignell merged commit 556edb6 into master Apr 2, 2019
@jsignell jsignell deleted the jsignell/new_colorsets branch April 2, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants