Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo for video - DO NOT MERGE! #414

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Demo for video - DO NOT MERGE! #414

wants to merge 2 commits into from

Conversation

Azaya89
Copy link
Collaborator

@Azaya89 Azaya89 commented Aug 13, 2024

This is just a demo PR for the video in our contribution website.

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@Azaya89 Azaya89 added the NF SDG NumFocus Software Development Grant 2024 label Aug 13, 2024
@Azaya89 Azaya89 marked this pull request as draft August 13, 2024 11:21
Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this was discussed already but did you consider using the template project? https://github.com/holoviz-topics/examples/tree/main/template It's meant to be used as a project contributors should copy/start from. There's special handling of this project in various places, for instance to avoid adding it to the production website (it is present on the dev website).
I'd like to avoid having two projects like that.

@Azaya89
Copy link
Collaborator Author

Azaya89 commented Aug 20, 2024

Not sure this was discussed already but did you consider using the template project? https://github.com/holoviz-topics/examples/tree/main/template It's meant to be used as a project contributors should copy/start from. There's special handling of this project in various places, for instance to avoid adding it to the production website (it is present on the dev website). I'd like to avoid having two projects like that.

I created this demo PR just to show the whole process of adding a new example. Using the template example itself wouldn't show how to create a new example fully, even though the data used for this demo example was gotten from the template directory.

Nevertheless, we can still delete this PR. It wasn't meant to be merged. It is only useful in the video, and not anywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NF SDG NumFocus Software Development Grant 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants