Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error handling for localhost #192

Closed
wants to merge 1 commit into from

Conversation

zeeshan595
Copy link

@zeeshan595 zeeshan595 commented Jun 8, 2023

Passing localhost does not work for hc sandbox running inside nix develop. Use 127.0.0.1 instead. Not sure if this change is needed maybe we can just update the docs to capture that

@jost-s
Copy link
Contributor

jost-s commented Jun 12, 2023

Yes, I've come across that too and changed all the tests to use 127.0.0.1. It's to do with Node.js having changed the preferred DNS resolution from IPv4 to IPv6. localhost will therefore resolve to ::1, and if your happ isn't also using IPv6 which I suppose it isn't doing, then the address cannot be found.

@jost-s jost-s closed this Aug 2, 2023
@jost-s jost-s deleted the fix/error-handling-for-localhost branch August 2, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants