Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse index note for DBML #83

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Parse index note for DBML #83

merged 1 commit into from
Apr 16, 2020

Conversation

phuongduyphan
Copy link
Collaborator

@phuongduyphan phuongduyphan commented Apr 16, 2020 •
edited
Loading

Summary

  • Parse index note for DBML

Issue

#82

Lasting Changes (Technical)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

khoahuynhdev
khoahuynhdev approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@khoahuynhdev khoahuynhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phuongduyphan phuongduyphan added pkg: core PR: Bug Fix 🐛 A type of pull request used for changelog categories labels Apr 16, 2020
@phuongduyphan phuongduyphan merged commit bc2440c into master Apr 16, 2020
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khoahuynhdev khoahuynhdev khoahuynhdev approved these changes

@khanh-tran-quoc khanh-tran-quoc Awaiting requested review from khanh-tran-quoc

Assignees
No one assigned
Labels
pkg: core PR: Bug Fix 🐛 A type of pull request used for changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phuongduyphan @khoahuynhdev