Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postgres connector issues #634

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Conversation

huyphung1602
Copy link
Collaborator

@huyphung1602 huyphung1602 commented Sep 10, 2024

Summary

Fix postgres connector issues related to:

  • Duplicated fields
  • Failed to fetch enums if there is the same enum_type name in different schemas.
    Fix wrong enums when fetching in mssql.

Issue

(issue link here)

Lasting Changes (Technical)

  • Fix the eslintrc to parse ts file correctly
  • Remove wrong enums when fetching in mssql
  • Update the sql which fetching tables, fields, and comments to avoid fetching duplicated fields
  • Update the sql which fetching enums to support the same enum_type name in different schema_name

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

- Update the sql which fetching tables, fields, and comments to  avoid fetching duplicated fields
- Update the sql which fetching enums to support the same enum_type name in different schema_name
Copy link
Contributor

@huyleminh01 huyleminh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huyphung1602 huyphung1602 merged commit 5fde440 into master Sep 11, 2024
3 checks passed
@huyphung1602 huyphung1602 deleted the fix-postgres-connector-issues branch September 11, 2024 05:49
@huyleminh01 huyleminh01 added the PR: Bug Fix 🐛 A type of pull request used for changelog categories label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 A type of pull request used for changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants