Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme for dbml core and connector #617

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

huyleminh01
Copy link
Contributor

Summary

  • Add readme.md for dbml connector
  • Fix broken link to the olde dbml core document page
  • Fix type definition for dbml core

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@huyleminh01 huyleminh01 added PR: Docs 📝 A type of pull request used for changelog categories PR: Refactor 🧹 labels Aug 19, 2024
@huyleminh01 huyleminh01 merged commit 92ae0b8 into master Aug 19, 2024
3 checks passed
@huyleminh01 huyleminh01 deleted the update-core-type-definition branch August 19, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 A type of pull request used for changelog categories PR: Refactor 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants