Support notes for table group #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update setting list validator of TableGroupValidator - Add setting list interpreter for TableGroupInterpreter - Update TableGroup interpreter - Update model_structure - Update testcases - Update pegjs
thonx-holistics
force-pushed
the
support-notes-for-table-group
branch
from
129bf95
to
6f8a13c
Compare
Huy-DNA
suggested changes
Aug 7, 2024
Comment on lines
77
to
94
| for (const name in settingMap) { | ||
| const attrs = settingMap[name]; | ||
| switch (name) { | ||
| case 'headercolor': | ||
| errors.push(...attrs.map((attr) => new CompileError(CompileErrorCode.INVALID_TABLE_SETTING, '\'headercolor\' is not supported', attr))) | ||
| break; | ||
| case 'note': | ||
| if (attrs.length > 1) { | ||
| errors.push(...attrs.map((attr) => new CompileError(CompileErrorCode.DUPLICATE_TABLE_SETTING, '\'note\' can only appear once', attr))) | ||
| } | ||
| attrs.forEach((attr) => { | ||
| if (!isExpressionAQuotedString(attr.value)) { | ||
| errors.push(new CompileError(CompileErrorCode.INVALID_TABLE_SETTING, '\'note\' must be a string literal', attr.value || attr.name!)); | ||
| } | ||
| }); | ||
| break; | ||
| default: | ||
| errors.push(...attrs.map((attr) => new CompileError(CompileErrorCode.INVALID_TABLE_SETTING, `Unknown \'${name}\' setting`, attr))) |
There was a problem hiding this comment.
This only need the default and note case
There was a problem hiding this comment.
I added the headercolor case because Table has it, and we may support it for Table Group in the future
NQPhuc
reviewed
Aug 12, 2024
packages/dbml-core/__tests__/parser/dbml-parse/input/table_group_settings.in.dbml
Outdated
Show resolved
Hide resolved
packages/dbml-core/__tests__/parser/dbml-parse/output/array_type.out.json
Outdated
Show resolved
Hide resolved
packages/dbml-parse/src/lib/analyzer/validator/elementValidators/tableGroup.ts
Outdated
Show resolved
Hide resolved
NQPhuc
approved these changes
Aug 14, 2024
thonx-holistics
added
the
PR: New Feature 🚀
Huy-DNA
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue
(issue link here)
Lasting Changes (Technical)
(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)
class EmailValidatorto validate email address' validity)Tenant#is_trial?check)Checklist
Please check directly on the box once each of these are done