Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DBML one-to-one relation exporting bug #57

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

dawitkk
Copy link

@dawitkk dawitkk commented Dec 27, 2019

Summary

Fixed a simple syntax error

Issue

This is related to issue #55
packages/dbml-core/src/export/DbmlExporter.js

Lasting Changes (Technical)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@phuongduyphan
Copy link
Collaborator

Hi there, thanks for spotting the bug in our code.

I suggest some improvements:

@phuongduyphan phuongduyphan added pkg: core PR: Bug Fix 🐛 A type of pull request used for changelog categories labels Dec 30, 2019
@dawitkk dawitkk changed the title fixed syntax error Fixed DBML one-to-one relation exporting bug Dec 30, 2019
@phuongduyphan phuongduyphan merged commit b0795c0 into holistics:master Dec 30, 2019
@phuongduyphan phuongduyphan changed the title Fixed DBML one-to-one relation exporting bug Fix DBML one-to-one relation exporting bug Jan 22, 2020
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: core PR: Bug Fix 🐛 A type of pull request used for changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants