Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate when redundant args & getMemberChain #515

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

Huy-DNA
Copy link
Contributor

@Huy-DNA Huy-DNA commented Feb 11, 2024

Summary

  • Fix the problem:
      Enum Person {
         id integer
      }
    
    go uncaught in the validator
  • The old bug was because the optional setting list was not treated properly.
  • Fix the error message of invalid enum field.
  • Fix the uncaught error in this situation:

image

Issue

(issue link here)

Lasting Changes (Technical)

  • getMemberChain takes ArrayNode into account
  • Enum and Ref validator

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@Huy-DNA Huy-DNA added the PR: Bug Fix 🐛 A type of pull request used for changelog categories label Feb 11, 2024
@Huy-DNA Huy-DNA self-assigned this Feb 15, 2024
@Huy-DNA Huy-DNA changed the title Fix validate when redundant args Fix validate when redundant args & getMemberChain Feb 15, 2024
Copy link
Contributor

@nguyenalter nguyenalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Huy-DNA Huy-DNA merged commit 6110ac9 into master Feb 15, 2024
3 checks passed
@Huy-DNA Huy-DNA deleted the fix-validate-when-redundant-args branch February 15, 2024 09:30
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 A type of pull request used for changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants