-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new DBML parser inconsistencies #488
Conversation
…re than 2 single quotes; Stop binding default indentifier to Enum; Keywords check in binder and intepreter is now case-insensivity; Update tests
This has been supported. However, there's a pitfall:
|
@HuyDNA I'm aware that since both table definition and column definition used the same rule (element-declaration), supporting array type for column would affect table definition as well. I think for now we can accept the new inconsistency cause to table setting. However, please help show a informative message to let the user know they need to leave empty space between table name and setting []. In the long run, we should consider breaking element-declaration into different declaration types, because as of right now, this is not very flexible. |
@NQPhuc All consistencies have been resolved. Plus the following benefits:
|
Summary
Resolve the following inconsistencies between old and new dbml parser behaviors:
Make keyworks check for default settings (true, false and null) case-insensitive.
Allow default value with double quote (v2 parser inconsistency with double-quoted list defaults #481)
Allow inline keywords in columns.
Issue
(issue link here)
Lasting Changes (Technical)
Checklist
Please check directly on the box once each of these are done