-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mysql ANTLR4 parser #486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenalter
approved these changes
Jan 9, 2024
NQPhuc
added
PR: Breaking Change 💥
A type of pull request used for changelog categories
PR: New Feature 🚀
A type of pull request used for changelog categories
labels
Jan 18, 2024
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: Breaking Change 💥
A type of pull request used for changelog categories
PR: New Feature 🚀
A type of pull request used for changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new mysql parser using
antlr
grammar (based on: https://github.com/antlr/grammars-v4/tree/master/sql/mysql/Positive-Technologies)The old postgres parser can still be used through:
sql2dbml --mysql-legacy
Implement
MySQLASTGen
visitor to generate the AST from the parse tree. Note that not all nodes will be visited in our visitor, only the nodes related to model_structure and thus DBML is.Update tests and doc.
Improve Error Handling for both Postgres and Mysql new parser to be able to throw multiple errors.
Note: Files in
ANTLR/parsers/mysql
are auto-generated and can be safely ignored.Benchmark result
Issue
start transaction
#465sql2dbml
cannot correctly parse simple mysql dumps #304Lasting Changes (Technical)
?.
Checklist
Please check directly on the box once each of these are done