Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ansi-regex, jsprim, loader-utils and minimist in /dbml-homepage #379

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

nguyenalter
Copy link
Contributor

@nguyenalter nguyenalter commented Apr 25, 2023

Summary

Bump packages to fix security issues:

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

- bump ansi-regex from 3.0.0 to 3.0.1
- bump ansi-regex from 4.1.0 to 4.1.1
- bump jsprim from 1.4.1 to 1.4.2
- bump loader-utils from 1.2.3 to 1.4.2
- bump minimist from 1.2.0 to 1.2.8
@nguyenalter nguyenalter requested a review from NQPhuc April 25, 2023 11:12
@nguyenalter nguyenalter changed the title Bump packages to fix security issues: Bump packages to fix security issues Apr 25, 2023
Copy link
Contributor

@NQPhuc NQPhuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should mention the issues that you want to fix in the description and in the tittle also. It'll be show on our changelog.

@nguyenalter nguyenalter added the PR: Dependencies Update 🤖 A type of pull request used for changelog categories label Apr 25, 2023
@nguyenalter nguyenalter changed the title Bump packages to fix security issues Bump ansi-regex, jsprim, loader-utils and minimist to fix security issues Apr 25, 2023
Copy link
Contributor

@NQPhuc NQPhuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nguyenalter nguyenalter merged commit d11ea2c into master Apr 25, 2023
@nguyenalter nguyenalter changed the title Bump ansi-regex, jsprim, loader-utils and minimist to fix security issues Bump ansi-regex, jsprim, loader-utils and minimist in /dbml-homepage Apr 25, 2023
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Dependencies Update 🤖 A type of pull request used for changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants