Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore on update current timestamp in mysql #297

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

baolequoc
Copy link
Contributor

@baolequoc baolequoc commented Oct 20, 2022

Summary

  • Ignore syntax ON UPDATE in fieldSettings

Issue

#279
#272
#141
#217
#237 (comment)

Lasting Changes (Technical)

  • Added grammar / _ "ON"i _ "UPDATE"i _ type { return "not_supported" } in fieldSettings in MySQL parser.

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@baolequoc baolequoc added the PR: Bug Fix 🐛 A type of pull request used for changelog categories label Oct 21, 2022
@baolequoc baolequoc requested a review from NQPhuc November 8, 2022 03:35
Copy link
Contributor

@NQPhuc NQPhuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@baolequoc baolequoc merged commit fa88b08 into master Nov 8, 2022
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 A type of pull request used for changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants