Fix building on MinGW #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please describe this change in detail? |
|
|
This code does not compile cleanly on all platforms we test with continuous integration. Please update it to ✅ on all three platforms before it can be considered for inclusion. |
|
@hobu I have pushed new changes, consider approving CI run. |
|
pushed new changes. |
hobu
approved these changes
May 13, 2024
abellgithub
reviewed
May 15, 2024
| @@ -129,7 +133,11 @@ std::vector<std::string> directoryList(const std::string& dir) | |||
| fs::directory_iterator end; | |||
| while (it != end) | |||
| { | |||
| #ifndef __MINGW32__ | |||
There was a problem hiding this comment.
I think that string() is totally sufficient. The macro tests can go away, along with the utwine::fromNative() call. But this needs to be testsed.
There was a problem hiding this comment.
string() doesn't work with MSVC compiler (It asks for wstring())
abellgithub
reviewed
May 15, 2024
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.