Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the exit code to QgisUntwine in case of no error message but no clean exit #159

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Feb 22, 2024

In the -hopefully rare- case that untwine crashes there is no error show to the user in QGIS (see qgis/QGIS#48307)

I wonder if this is a good approach to tackle this, by propagating the exit code from the untwine process to the QgisUntwine::errorMessage ...

@abellgithub abellgithub merged commit c19046b into hobuinc:main Feb 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants