Fix intersection parameter, relay exceptions #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
j9ac9k
force-pushed
the
fix-intersection
branch
2 times, most recently
from
a2a4aa4 to
7d9a46c
Compare
* In the case of a GRiD error at the AOI export, raise a RuntimeError * In the case of a GRiD error at the export endpoint, emit a UserWarning In both cases, the contents of the error are relayed back to the user This commit also makes some minor changes * Fix a Python 3.9 type annotations syntax incompatibility * Set the httpx logger level to 'warning' * Set some of the doppkit logger levels to DEBUG from INFO to not spam the console so much
When fetching already made exports, there is no need to check for if the exporters intersect with the AOI boundary. That said, when creating the exports we still want to split an export along the boundary of the specified AOI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @sambaldwin05 for the report and the suggested fix.