Handle date parsing gracefully

hoarder-app · Dec 23, 2024 · bebfec1 · bebfec1
1 parent 43ce119
commit bebfec1
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 14 deletions.
diff --git a/apps/web/components/dashboard/search/QueryExplainerTooltip.tsx b/apps/web/components/dashboard/search/QueryExplainerTooltip.tsx
@@ -31,6 +31,20 @@ export default function QueryExplainerTooltip({
             <TableCell>{matcher.listName}</TableCell>
           </TableRow>
         );
+      case "dateAfter":
+        return (
+          <TableRow>
+            <TableCell>Created After</TableCell>
+            <TableCell>{matcher.dateAfter.toDateString()}</TableCell>
+          </TableRow>
+        );
+      case "dateBefore":
+        return (
+          <TableRow>
+            <TableCell>Created Before</TableCell>
+            <TableCell>{matcher.dateBefore.toDateString()}</TableCell>
+          </TableRow>
+        );
       case "favourited":
         return (
           <TableRow>

diff --git a/packages/shared/searchQueryParser.ts b/packages/shared/searchQueryParser.ts
@@ -169,21 +169,37 @@ MATCHER.setPattern(
               matcher: { type: "listName", listName: toks[1] },
             };
           case "after:":
-            return {
-              text: "",
-              matcher: {
-                type: "dateAfter",
-                dateAfter: z.coerce.date().parse(toks[1]),
-              },
-            };
+            try {
+              return {
+                text: "",
+                matcher: {
+                  type: "dateAfter",
+                  dateAfter: z.coerce.date().parse(toks[1]),
+                },
+              };
+            } catch (e) {
+              return {
+                // If parsing the date fails, emit it as pure text
+                text: toks[0].text + toks[1],
+                matcher: undefined,
+              };
+            }
           case "before:":
-            return {
-              text: "",
-              matcher: {
-                type: "dateBefore",
-                dateBefore: z.coerce.date().parse(toks[1]),
-              },
-            };
+            try {
+              return {
+                text: "",
+                matcher: {
+                  type: "dateBefore",
+                  dateBefore: z.coerce.date().parse(toks[1]),
+                },
+              };
+            } catch (e) {
+              return {
+                // If parsing the date fails, emit it as pure text
+                text: toks[0].text + toks[1],
+                matcher: undefined,
+              };
+            }
           default:
             // If the token is not known, emit it as pure text
             return {