Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

chore(php) Move to PHP 7 #27

Merged
merged 11 commits into from
Jan 23, 2018
Merged

chore(php) Move to PHP 7 #27

merged 11 commits into from
Jan 23, 2018

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Nov 6, 2017

@Pierozi
Copy link
Member

Pierozi commented Nov 6, 2017

Congrats, a major one! everything is moved to Source for better design where actual code base should be?
Should we apply this to every PHP7.1 PR?

@Hywan
Copy link
Member Author

Hywan commented Nov 7, 2017

@Pierozi Yes. And yes :-).

This is WIP. It's very hard to test because hoa/test depends on libraries, which depends on hoa/test to test them… I've a weird local configuration. Hope I will close the loop soon, and we will iterate over other libraries more easily.

@Bhoat Bhoat merged commit 99860ba into hoaproject:master Jan 23, 2018
@ghost ghost removed the in progress label Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants