Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 Rewrite #196

Merged
merged 9 commits into from
Jul 3, 2022
Merged

V1 Rewrite #196

merged 9 commits into from
Jul 3, 2022

Conversation

hoangvvo
Copy link
Owner

@hoangvvo hoangvvo commented Jul 2, 2022

This is the rewrite of next-connect. There are many breaking changes. See README.md for more detail.

The motivation of this rewrite is to:

With this, we will be heading for 1.0! 0.x version will still be supported (I am planning to make some semi-breaking changes to correct some behaviors, esp. the two in the last bullet point above, as well as fixing some bugs) Close #126

Check out the example: https://github.com/hoangvvo/next-connect/tree/v1-rewrite/examples/nextjs

@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2022

⚠️ No Changeset found

Latest commit: 9581197

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@merlindru
Copy link

merlindru commented Jul 2, 2022

Awesome!!! Thank you for your hard work! 🙂

What's required to get this landed?

Could we get an npm release? npm i next-connect@next or @beta would be cool!

@hoangvvo hoangvvo changed the title next-connect rewrite V1 Rewrite Jul 2, 2022
@hoangvvo
Copy link
Owner Author

hoangvvo commented Jul 2, 2022

Awesome!!! Thank you for your hard work! slightly_smiling_face

What's required to get this landed?

Could we get an npm release? npm i next-connect@next or @beta would be cool!

This should be landing soon 🚀

@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #196 (9581197) into main (e55318a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main      #196    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1         3     +2     
  Lines           86       248   +162     
  Branches         0        43    +43     
==========================================
+ Hits            86       248   +162     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/node.ts 100.00% <100.00%> (ø)
src/router.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55318a...9581197. Read the comment docs.

@hoangvvo hoangvvo merged commit d1ecbc8 into main Jul 3, 2022
@hoangvvo
Copy link
Owner Author

hoangvvo commented Jul 3, 2022

Published as next!

npm i next-connect@next

@hoangvvo hoangvvo deleted the v1-rewrite branch July 6, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment