Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression away from express API #161

Open
jimisaacs opened this issue Oct 28, 2021 · 0 comments
Open

Possible regression away from express API #161

jimisaacs opened this issue Oct 28, 2021 · 0 comments

Comments

@jimisaacs
Copy link

jimisaacs commented Oct 28, 2021

So before this commit: b3fede1

an API consumer was passing an array of functions as base without a problem. As this documentation shows should be allowed, if this is a drop-in replacement for express: https://expressjs.com/en/api.html#app.use

A string representing a path.
A path pattern.
A regular expression pattern to match paths.
An array of combinations of any of the above.

Though checking for function breaks that contract, and is breaking the API consumer I mentioned after this change.

jimisaacs added a commit to jimisaacs/next-connect that referenced this issue Oct 29, 2021
jimisaacs added a commit to jimisaacs/next-connect that referenced this issue Oct 29, 2021
jimisaacs added a commit to jimisaacs/next-connect that referenced this issue Apr 10, 2022
jimisaacs added a commit to jimisaacs/next-connect that referenced this issue Apr 10, 2022
jimisaacs added a commit to jimisaacs/next-connect that referenced this issue Apr 10, 2022
jimisaacs added a commit to jimisaacs/next-connect that referenced this issue Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant