GG-6854 - Restrict test dependencies to test scope (Security issue) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove scalacheck's Gen from production code using just a random generator to replace Gen; remove property testing from the class as it was not adding value to the test
|
fix all the compiler errors and warnings
|
remove jre8 dependent wiremock test lib as it was breaking tests and hmrc is using jre11 already
|
|
ModisR
suggested changes
May 12, 2023
|
|
||
| def getFlags = { | ||
| def getFlags: Action[AnyContent] = { | ||
| Action.async { implicit request => | ||
| Future(Ok(currentFeatureSwitchesAsJson)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice. If the implicit request parameter is unused, you can invoke the action builder without the underscore parameter thusly:
def getFlags: Action[AnyContent] = Action {
Ok(currentFeatureSwitchesAsJson)
}| align { | ||
| preset = more | ||
| tokens = [ | ||
| "extends", |
There was a problem hiding this comment.
Add ":" to these tokens to maintain alignment of type annotations in parameter lists. The Scalariform config had something to align parameter type annotations so continuing the tradition with Scalafmt will make the diff a little quieter.
project/AppDependencies.scala
Outdated
| "org.mockito" %% "mockito-scala-scalatest" % "1.17.12" % testScope, | ||
| "org.scalacheck" %% "scalacheck" % "1.17.0" % testScope, | ||
| "com.github.fge" % "json-schema-validator" % "2.2.6" % testScope, | ||
| "com.vladsch.flexmark" % "flexmark-all" % "0.64.0" % testScope | ||
| ) |
There was a problem hiding this comment.
I think instead of assigning testScope to a val, it's better to just put .map(_ % "test, it") here.
| compilerPlugin("com.github.ghik" % "silencer-plugin" % "1.7.9" cross CrossVersion.full), | ||
| "com.github.ghik" % "silencer-lib" % "1.7.9" % Provided cross CrossVersion.full | ||
| compilerPlugin("com.github.ghik" % "silencer-plugin" % silencerVersion cross CrossVersion.full), | ||
| "com.github.ghik" % "silencer-lib" % silencerVersion % Provided cross CrossVersion.full |
project/plugins.sbt
Outdated
| addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.19") | ||
| addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.6") | ||
| addSbtPlugin("org.scalariform" % "sbt-scalariform" % "1.8.3") |
ModisR
suggested changes
May 15, 2023
|
|
||
| def getFlags = { | ||
| def getFlags: Action[AnyContent] = { | ||
| Action.async { implicit request => | ||
| Future(Ok(currentFeatureSwitchesAsJson)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice. If the implicit request parameter is unused, you can invoke the action builder without the underscore parameter thusly:
def getFlags: Action[AnyContent] = Action {
Ok(currentFeatureSwitchesAsJson)
}use Action's default constructor
ModisR
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.tools.tax.service.gov.uk/browse/GG-6854