BDOG-1512 Adds HttpClient2 to support streams, withProxy etc. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilder style syntax
…erloaded body variants)
…t-type is x-www-form-urlencoded
Remove 'do you need to be auditing this payload' from log message, since there's no way to address the warning
tomwadeson
reviewed
Jan 14, 2022
http-verbs-common/src/main/scala/uk/gov/hmrc/http/client2/HttpClient2.scala
Outdated
Show resolved
Hide resolved
http-verbs-common/src/main/scala/uk/gov/hmrc/http/client2/package.scala
Outdated
Show resolved
Hide resolved
http-verbs-common/src/main/scala/uk/gov/hmrc/http/client2/package.scala
Outdated
Show resolved
Hide resolved
* BDOG-1512 Fix error parsing for streams * BDOG-1512 Rename proxy.enabled to http-verbs.proxy.enabled
chotai
reviewed
Feb 9, 2022
http-verbs-common/src/main/scala/uk/gov/hmrc/http/HttpReadsLegacyInstances.scala
Outdated
Show resolved
Hide resolved
http-verbs-common/src/main/scala/uk/gov/hmrc/http/HttpReadsLegacyInstances.scala
Outdated
Show resolved
Hide resolved
|
|
||
| import java.net.ServerSocket | ||
|
|
||
| object PortFinder { |
There was a problem hiding this comment.
does this class exist in http-verbs-test-common? Would be good if we can find a way to only have the class defined once
http-verbs-common/src/main/scala/uk/gov/hmrc/http/Retries.scala
Outdated
Show resolved
Hide resolved
http-verbs-common/src/main/scala/uk/gov/hmrc/http/client2/HttpClient2Impl.scala
Outdated
Show resolved
Hide resolved
http-verbs-test-common/src/main/scala/uk/gov/hmrc/http/test/HttpClient2Support.scala
Outdated
Show resolved
Hide resolved
http-verbs-test-common/src/main/scala/uk/gov/hmrc/http/test/HttpClientSupport.scala
Show resolved
Hide resolved
colin-lamed
force-pushed
the
BDOG-1512
branch
from
16b9f3a
to
f7f52dd
Compare
chotai
previously approved these changes
Feb 16, 2022
chotai
previously approved these changes
Feb 16, 2022
chotai
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.