Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSCSSI-34: merge evidence share to tribunals api #3671
SSCSSI-34: merge evidence share to tribunals api #3671
Changes from all commits
0585bec
e4bcb14
f980de1
b2d68f1
dfd9b5c
2eaa8ad
0678d11
1d276d5
de93dc1
45f496b
88a1eab
084d62b
7b76536
965ff96
bf337fd
36a407b
b67f1ea
77c5ac4
eed4999
3d75664
aee640a
3a966a4
df3f45b
baad0f1
9d5206e
9dea705
3ff6761
06ad77e
0abe084
917b377
70778be
d60801d
eb412ef
e5972be
66df339
a401cf4
98fc066
c98611b
e736dda
b2ca701
80779f8
6d0468a
1819b7b
c89823a
cdb6b30
53862a0
59ccfb6
cad1d04
6cc1904
d2356d6
2b0c89e
381d303
80335b6
5b8cdda
d0c9db7
7927b77
45f2f6b
3057bd8
2602cfa
41db1ac
5d64eed
8ca505e
5f64fc2
cdd7bce
b0f81e8
ac82435
a384858
bd572c5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a case for moving to EM document-generation with docmosis, rather than using the old pdf-service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all these feature flags still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a general observation some env vars uses "" and some without "" may be we can make them consistent while you are here :)