Skip to content

Commit

Permalink
Merge pull request #1794 from hmcts/rst-6763
Browse files Browse the repository at this point in the history
RST-6763 Update changes in wages text
  • Loading branch information
eyss1234 authored Jul 24, 2024
2 parents 840e0ff + f0069e9 commit f35ad6b
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions app/helpers/evidence_check_helper.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module EvidenceCheckHelper
SECTION_TO_INCOME_KIND_MAPPING = {
'wages' => ["Wages", "Net profits from self employment", "Pensions (state, work, private)",
"Pensions (state, work, private, pension credit (savings credit))"],
'wages' => ["Wages before tax and National Insurance are taken off", "Net profits from self employment",
"Pensions (state, work, private)", "Pensions (state, work, private, pension credit (savings credit))"],
'child_maintenance' => ["Maintenance payments"],
'rental' => ["Rent from anyone living with the applicant", "Rent from other properties the applicant owns",
"Rent from anyone living with the partner", "Rent from other properties the partner owns",
Expand Down
2 changes: 1 addition & 1 deletion charts/help-with-fees-staffapp/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: '1.0'
description: A Helm chart for hwf-staffapp App
name: help-with-fees-staffapp
home: https://github.com/hmcts/hwf-staffapp
version: 0.0.55
version: 0.0.56
dependencies:
- name: base
version: 1.3.0
Expand Down
4 changes: 2 additions & 2 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ en-GB:
forms/application/income_kind_applicant:
income_kind_applicant: 'In question 12, what types of income has the applicant received over the last three months?'
kinds:
'1': Wages
'1': Wages before tax and National Insurance are taken off
'2': Net profits from self employment
'3': Child benefit
'4': Working Tax Credit
Expand All @@ -658,7 +658,7 @@ en-GB:
forms/application/income_kind_partner:
income_kind_partner: "In question 12, what types of income has the applicant's partner received over the last three months?"
kinds:
'1': Wages
'1': Wages before tax and National Insurance are taken off
'2': Net profits from self employment
'3': Child benefit
'4': Working Tax Credit
Expand Down
2 changes: 1 addition & 1 deletion features/step_definitions/fee_status_steps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
end

When('I choose wages') do
expect(income_kind_applicant_page.content.checkboxes[0].text).to eq('Wages')
expect(income_kind_applicant_page.content.checkboxes[0].text).to eq('Wages before tax and National Insurance are taken off')
income_kind_applicant_page.content.checkboxes[0].click
income_kind_applicant_page.content.next.click
end
2 changes: 1 addition & 1 deletion spec/helpers/evidence_check_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
it { expect(display_evidence_section?(application, 'wage')).to be false }
end

["Wages", "Net profits from self employment", "Pensions (state, work, private)",
["Wages before tax and National Insurance are taken off", "Net profits from self employment", "Pensions (state, work, private)",
"Pensions (state, work, private, pension credit (savings credit))"].each do |income_kind_value|
context 'Wages' do
let(:income_kind) { { applicant: [income_kind_value] } }
Expand Down
2 changes: 1 addition & 1 deletion spec/helpers/income_kind_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
end

context 'when application has kind' do
let(:application) { build_stubbed(:application, income_kind: { applicant: ['Wages'] }) }
let(:application) { build_stubbed(:application, income_kind: { applicant: ['Wages before tax and National Insurance are taken off'] }) }
let(:form) { Forms::Application::IncomeKindApplicant }
let(:claimant) { :applicant }
let(:kind) { 1 }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
end

it 'saves the parameters in the detail' do
expect(application.income_kind).to eq({ applicant: ['Wages'], partner: ['test2'] })
expect(application.income_kind).to eq({ applicant: ['Wages before tax and National Insurance are taken off'], partner: ['test2'] })
end
end

Expand Down
2 changes: 1 addition & 1 deletion spec/models/forms/application/income_kind_partner_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
end

it 'saves the parameters in the detail' do
expect(application.income_kind).to eq({ applicant: ['test'], partner: ['Wages'] })
expect(application.income_kind).to eq({ applicant: ['test'], partner: ['Wages before tax and National Insurance are taken off'] })
end
end

Expand Down

0 comments on commit f35ad6b

Please sign in to comment.