Optionally enable video recording in zalenium

hmcts · Jan 10, 2020 · d54e45e · d54e45e
1 parent 676cbf8
commit d54e45e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    et_full_system (1.0.0.pre48)
+    et_full_system (1.0.0.pre49)
       aws-sdk-s3 (~> 1.9)
       azure-storage (~> 0.15.0.preview)
       dotenv (~> 2.7, >= 2.7.2)
@@ -72,7 +72,7 @@ GEM
     httparty (0.17.3)
       mime-types (~> 3.0)
       multi_xml (>= 0.5.2)
-    i18n (1.7.1)
+    i18n (1.8.0)
       concurrent-ruby (~> 1.0)
     iodine (0.7.38)
     jmespath (1.4.0)

diff --git a/docker/docker-compose.yml b/docker/docker-compose.yml
@@ -157,7 +157,7 @@ services:
             --maxDockerSeleniumContainers 8
             --screenWidth 1024 --screenHeight 768
             --timeZone "Europe/Berlin"
-            --videoRecordingEnabled false
+            --videoRecordingEnabled ${RECORD_VIDEO:-false}
             --sauceLabsEnabled false
             --browserStackEnabled false
             --testingBotEnabled false

diff --git a/lib/et_full_system/cli/docker/server.rb b/lib/et_full_system/cli/docker/server.rb
@@ -14,12 +14,14 @@ class ServerCommand < Thor
         method_option :use_selenium, type: :boolean, default: true, aliases: 'use-selenium', desc: 'Only used if with_test is true - says to use selenium in preference to zalenium'
         method_option :chrome_instances, type: :numeric, default: 1, aliases: 'chrome-instances', desc: 'Specify the number of chrome instances for selenium'
         method_option :firefox_instances, type: :numeric, default: 1, aliases: 'firefox-instances', desc: 'Specify the number of firefox instances for selenium'
+        method_option :record_video, type: :boolean, default: true, aliases: 'record-video', desc: 'When using zalenium, enable video recording'
         def up(*args)
           Bundler.with_original_env do
             server_args = []
             server_args << "--without=#{options[:without].join(' ')}" unless options[:without].empty?
             env_vars = ["SERVER_ARGS='#{server_args.join(' ')}'"]
             env_vars << "LOCALHOST_FROM_DOCKER_IP=#{host_ip}"
+            env_vars << "RECORD_VIDEO=#{options.record_video?}"
             if options.ccd_docker?
               env_vars << "CCD_AUTH_BASE_URL=http://#{options.ccd_docker_host}:4502"
               env_vars << "CCD_IDAM_BASE_URL=http://#{options.ccd_docker_host}:5000"

diff --git a/lib/et_full_system/version.rb b/lib/et_full_system/version.rb
@@ -1,3 +1,3 @@
 module EtFullSystem
-  VERSION = "1.0.0.pre48"
+  VERSION = "1.0.0.pre49"
 end