Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMP-3408: Update event endpoint with associated hearings #2651

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Ben-Edwards-cgi
Copy link
Contributor

Links

Jira

Change description

Summary of Git Diff

This Git diff introduces enhancements to the EventEntity class and related components, mainly adding new functionality to manage linked cases and hearings. It also modifies the API response structures and updates the corresponding tests to ensure that the new features work correctly.

Highlights

  • New Relationships:

    • Introduced a one-to-many relationship in EventEntity with eventLinkedCaseEntities.
  • New Method:

    • Added the getLinkedCases() method to retrieve linked cases from eventLinkedCaseEntities.
  • API Response Changes:

    • Changed the return type in EventsController and EventService from AdminGetEventResponseDetails to AdminGetEventById200Response.
    • Updated OpenAPI specifications to reflect new response structures that include cases and hearings.
  • Mapper Enhancements:

    • Updated EventMapper to handle mapping for new response details related to cases and hearings.
    • Introduced several private methods for mapping case and hearing data.
  • Testing Improvements:

    • Added extensive unit tests for the new functionalities in both EventEntity and EventMapper to ensure robustness and correctness of the new logic.
  • Library Utilization:

    • Utilized CollectionUtils from Apache Commons Collections to simplify null and empty checks in the new methods.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant