generated from hmcts/spring-boot-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMP-3392: Include pre-amble/post-amble in job that links cases to audio through events #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackmaloney
approved these changes
Feb 27, 2025
davet1985
reviewed
Feb 28, 2025
davet1985
approved these changes
Feb 28, 2025
src/main/java/uk/gov/hmcts/darts/task/runner/impl/AudioLinkingAutomatedTask.java
Outdated
Show resolved
Hide resolved
Added additional tests to ensure the logic works how we want it too
chrisbellingham-hmcts
approved these changes
Mar 3, 2025
davet1985
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Change description
Summary of Git Diff
This Git Diff introduces changes to the
AudioConfigurationProperties
and related classes to update the data types of certain properties fromInteger
toDuration
forpreAmbleDuration
andpostAmbleDuration
. This change is reflected throughout the service implementation and the application configuration files to ensure consistent handling of audio timing.Highlights
Property Type Changes:
preAmbleDuration
andpostAmbleDuration
fromInteger
toDuration
inAudioConfigurationProperties.java
.Service Logic Updates:
AudioAsyncServiceImpl.java
andAudioLinkingAutomatedTask.java
to useDuration
for calculating the start and end times instead of minutes offset.Configuration Changes:
application.yaml
, the duration values forpre-amble-duration
andpost-amble-duration
are modified to include the unit (30m
instead of30
).Test Adjustments:
AudioLinkingAutomatedTaskTest.java
to reflect the newDuration
handling for pre- and post-amble durations.These changes aim to enhance the clarity and functionality of the audio processing logic by leveraging
Duration
types for better time management.Does this PR introduce a breaking change? (check one with "x")