Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMP-3392: Include pre-amble/post-amble in job that links cases to audio through events #2647

Merged
merged 9 commits into from
Mar 3, 2025

Conversation

Ben-Edwards-cgi
Copy link
Contributor

Links

Jira

Change description

Summary of Git Diff

This Git Diff introduces changes to the AudioConfigurationProperties and related classes to update the data types of certain properties from Integer to Duration for preAmbleDuration and postAmbleDuration. This change is reflected throughout the service implementation and the application configuration files to ensure consistent handling of audio timing.

Highlights

  • Property Type Changes:

    • Changed preAmbleDuration and postAmbleDuration from Integer to Duration in AudioConfigurationProperties.java.
  • Service Logic Updates:

    • Updated the methods in AudioAsyncServiceImpl.java and AudioLinkingAutomatedTask.java to use Duration for calculating the start and end times instead of minutes offset.
  • Configuration Changes:

    • In application.yaml, the duration values for pre-amble-duration and post-amble-duration are modified to include the unit (30m instead of 30).
  • Test Adjustments:

    • Updated the test cases in AudioLinkingAutomatedTaskTest.java to reflect the new Duration handling for pre- and post-amble durations.

These changes aim to enhance the clarity and functionality of the audio processing logic by leveraging Duration types for better time management.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@Ben-Edwards-cgi Ben-Edwards-cgi enabled auto-merge (squash) February 28, 2025 14:52
Added additional tests to ensure the logic works how we want it too
@Ben-Edwards-cgi Ben-Edwards-cgi merged commit 2605352 into master Mar 3, 2025
10 checks passed
@Ben-Edwards-cgi Ben-Edwards-cgi deleted the DMP-3392 branch March 3, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants