DMP-4739: Improve automated task - ArmRetentionEventDateCalculator #2646
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-Edwards-cgi
requested review from
davet1985,
jackmaloney,
cakeben,
ciaranca,
reespozzi and
ConnorOKane-Kainos
and removed request for
a team
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2646
labels
chrisbellingham-hmcts
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Change description
To prevent any potential race conditions when obtaining a batch of data and updating the object when it gets to it, modify the method ArmRetentionEventDateProcessorImpl calculateEventDates so that it gets the ExternalObjectDirectoryEntity objects id's and then pass to armRetentionEventDateCalculator.calculateRetentionEventDate
Does this PR introduce a breaking change? (check one with "x")