generated from hmcts/spring-boot-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMP-3396: Implement get audio versions endpoint #2641
Open
Ben-Edwards-cgi
wants to merge
7
commits into
master
Choose a base branch
from
DMP-3396
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a80f43
to
ea7d204
Compare
This Pr depends on changes in: #2628 |
src/main/java/uk/gov/hmcts/darts/audio/service/impl/AdminMediaServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/darts/audio/service/impl/AdminMediaServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/darts/audio/service/impl/AdminMediaServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/darts/audio/service/impl/AdminMediaServiceImpl.java
Outdated
Show resolved
Hide resolved
src/test/java/uk/gov/hmcts/darts/audio/service/impl/AdminMediaServiceImplTest.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/darts/audio/service/impl/AdminMediaServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/darts/audio/mapper/GetAdminMediaResponseMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/darts/audio/service/impl/AdminMediaServiceImpl.java
Show resolved
Hide resolved
chrisbellingham-hmcts
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Change description
Summary of Changes in Git Diff
This commit introduces a new integration test for the
AudioController
, specifically for the endpoint that retrieves media versions by ID. It also updates several Java files to support this new functionality, including the addition of new response models and the corresponding service and controller methods.Highlights
New Integration Test:
AudioControllerGetAdminMediaVersionsByIdIntTest.java
is created for testing various scenarios of fetching media versions by ID.New Response Models:
AdminVersionedMediaResponse
andAdminMediaVersionResponse
to structure the responses for media version requests.Controller Enhancements:
AudioController.java
to include a new endpoint for fetching media versions, with appropriate security annotations.Service Layer Updates:
AdminMediaService.java
and its implementation are updated to include the logic for retrieving media versions by ID.chronicleId
.Database Queries:
MediaRepository.java
to fetch all media entities bychronicleId
.OpenAPI Documentation:
audio.yaml
to include the new endpoint documentation for fetching media versions.Error Handling Improvements:
chronicleId
is null for media entities.Unit Tests:
These changes collectively enhance the functionality of the audio management system by allowing users to retrieve detailed version information for specific media records while ensuring robust error handling and authorization checks.
Does this PR introduce a breaking change? (check one with "x")