Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CME-110: Apply NullifyByDefault to a field when it is set to True/Yes #2505

Open
wants to merge 76 commits into
base: master
Choose a base branch
from
Open

CME-110: Apply NullifyByDefault to a field when it is set to True/Yes #2505

wants to merge 76 commits into from

Conversation

kiran-yenigala-hmcts
Copy link
Contributor

@kiran-yenigala-hmcts kiran-yenigala-hmcts commented Dec 4, 2024 •
edited by aktaskaan
Loading

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/CME-110

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview December 16, 2024 20:12 Abandoned
@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview December 16, 2024 20:22 Abandoned
@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview December 16, 2024 20:58 Abandoned
@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview February 4, 2025 16:10 Abandoned
@aktaskaan aktaskaan self-requested a review February 6, 2025 09:52
aktaskaan
aktaskaan requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@aktaskaan aktaskaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 63 commits in the PR, and it would be good to reduce this number by rebasing the feature branch onto the latest master to avoid extra merge commits and keep the history cleaner.

build.gradle Outdated
@@ -337,7 +337,7 @@ dependencies {
implementation 'org.jooq:jool-java-8:0.9.14'
implementation 'com.github.hmcts:ccd-case-document-am-client:1.7.1'

testImplementation group: 'com.github.hmcts', name: 'ccd-test-definitions', version: '7.24.2'
testImplementation group: 'com.github.hmcts', name: 'ccd-test-definitions', version: '7.24.2-prerelease-CME-110-8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should be changed with the stable release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patelila patelila patelila left review comments

@aktaskaan aktaskaan aktaskaan requested changes

@danlysiak danlysiak Awaiting requested review from danlysiak

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
aat/no-changes ns:ccd prd:ccd prod/no-changes rel:ccd-data-store-api-pr-2505
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiran-yenigala-hmcts @danlysiak @aktaskaan @patelila