sonar fixes

hmcts · Dec 12, 2024 · 9c9545c · 9c9545c
1 parent 12b3de6
commit 9c9545c
Show file tree

Hide file tree

Showing 2 changed files with 240 additions and 447 deletions.
diff --git a/src/main/java/uk/gov/hmcts/ccd/domain/service/common/RestrictedFieldProcessor.java b/src/main/java/uk/gov/hmcts/ccd/domain/service/common/RestrictedFieldProcessor.java
@@ -27,6 +27,8 @@
 @Service
 public class RestrictedFieldProcessor {
 
+    private static final String VALUE = "value";
+
     private final CaseAccessService caseAccessService;
 
     public RestrictedFieldProcessor(CaseAccessService caseAccessService) {
@@ -146,8 +148,8 @@ private JsonNode processCollectionFields(CaseFieldDefinition subFieldDefinition,
                     sanitizedArray.add(existingItem);
                 }
             } else {
-                JsonNode newValueField = matchingNewItem.get().get("value");
-                JsonNode existingValueField = existingItem.get("value");
+                JsonNode newValueField = matchingNewItem.get().get(VALUE);
+                JsonNode existingValueField = existingItem.get(VALUE);
 
                 if (existingValueField != null) {
                     JsonNode processedValueField;
@@ -162,7 +164,7 @@ private JsonNode processCollectionFields(CaseFieldDefinition subFieldDefinition,
                             subFieldDefinition, newValueField, existingValueField, accessProfileNames);
                     }
 
-                    ((ObjectNode) matchingNewItem.get()).set("value", processedValueField);
+                    ((ObjectNode) matchingNewItem.get()).set(VALUE, processedValueField);
                 }
             }
         }