EXUI-1848 - reduce translation of untranslatable text #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-1848
Change description
This change makes the label substituter directive sensitive to translation. If a field has placeholders in it, the label substituter passes the unsubstituted text to the translation pipe directly, and sets a flag on the field to say that it has already been translated. It then does it's regular substitution on the translated text.
When the label field is displayed, it checks the caseField isTranslated flag, and doesn't send a field label that is marked as translated to the translation service again.
Does this PR introduce a breaking change? (check one with "x")
Hopefully not