Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PREVIEW] Rdm 3694 preview #135

Merged
merged 4 commits into from
Jan 23, 2019
Merged

[PREVIEW] Rdm 3694 preview #135

merged 4 commits into from
Jan 23, 2019

Conversation

adr1ancho
Copy link
Contributor

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 21, 2019 09:22 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 21, 2019 09:28 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 21, 2019 09:30 Inactive
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #135 into master will decrease coverage by 2.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   89.89%   87.04%   -2.85%     
==========================================
  Files          32       33       +1     
  Lines         277      664     +387     
  Branches       24       77      +53     
==========================================
+ Hits          249      578     +329     
- Misses         16       58      +42     
- Partials       12       28      +16
Impacted Files Coverage Δ
src/main/routes/importDefinition.ts 41.17% <0%> (-58.83%) ⬇️
src/main/routes/jurisdiction.ts 64.7% <0%> (-35.3%) ⬇️
src/main/service/import-service.ts 78.94% <0%> (-21.06%) ⬇️
src/main/routes/updateUser.ts 93.33% <0%> (-6.67%) ⬇️
src/main/app-insights/app-insights.ts 54.54% <0%> (-5.46%) ⬇️
src/main/routes/userRoles.ts 80.9% <0%> (-3.47%) ⬇️
src/main/app.test.ts 93.18% <0%> (-0.94%) ⬇️
src/main/service/delete-user-service.ts 100% <0%> (ø) ⬆️
src/main/validators/validateUserProfile.ts 100% <0%> (ø) ⬆️
src/main/user/user-request-authorizer.ts 100% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bcd04...43f7a54. Read the comment docs.

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 21, 2019 14:36 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 21, 2019 14:37 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 21, 2019 14:42 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 21, 2019 14:57 Inactive
@adr1ancho adr1ancho requested a review from Daniel-Lam January 21, 2019 16:06
Copy link
Contributor

@Daniel-Lam Daniel-Lam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 22, 2019 16:35 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 22, 2019 16:36 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 22, 2019 16:36 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 23, 2019 10:49 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 23, 2019 10:51 Inactive
@agilks agilks self-requested a review January 23, 2019 11:07
Copy link
Contributor

@agilks agilks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - on behalf of Ashish

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 23, 2019 11:16 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 23, 2019 11:18 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 23, 2019 11:42 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 23, 2019 11:43 Inactive
@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files          34       34           
  Lines         695      695           
  Branches       83       83           
=======================================
  Hits          606      606           
  Misses         61       61           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e089631...45b9abb. Read the comment docs.

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 23, 2019 13:47 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview January 23, 2019 13:48 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 23, 2019 14:53 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview January 23, 2019 14:55 Inactive
@agilks agilks merged commit 228d862 into master Jan 23, 2019
@agilks agilks deleted the RDM-3694-preview branch January 23, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants