Auto approve any pull request with the pull-request-number input

[roryabraham]

Fixed issue

Fixes #21

Details

This PR makes it so that this action can be utilized from a workflow triggered by the workflow_dispatch event by adding an optional pull_request_number input. If provided, we will auto-approve that pull request, rather than relying on the pull_request from the GitHub context.

Happy to provide more details or changes as you see fit! Thanks!

Context

I am trying to make a workflow that can be triggered by other workflows/actions that:

1. Creates a new app version
2. Creates a pull request to update the version on the main branch
3. Auto-approves and auto-merges that pull request.

This way, my other workflows can perform the above steps and wait for the workflow to complete and the version update to be present on the main branch. This will go a long way in simplifying my CI/CD code and in preventing race conditions.

[hmarr]

Thanks for submitting this!

I've added a few relatively minor comments.

Additionally, I noticed that the package-lock.json has changed quite a lot, and the lockfile format switched from v2 to v1. Would you mind reverting that change? I assume it's because you're using an older version of npm.

[hmarr]

To avoid the hard-coded example number, perhaps this snippet could use workflow_dispatch inputs so we could change this to a dynamic value.

Alternatively, if you're looking to run this workflow after another Actions workflow that generates a pull request, workflow_run might be the trigger you're looking for?

[roryabraham]

Done!

Alternatively, if you're looking to run this workflow after another Actions workflow that generates a pull request, workflow_run might be the trigger you're looking for?

Thanks for the suggestion! Actually, I currently have my automerge workflow happening in response to the pull_request event, and it is successfully triggered after the workflow that generates a pull request. In case you're wondering why I submitted this PR, I am effectively trying to make a "subroutine" that:

1. Generates a new version
2. Creates a PR to update the main branch with that version
3. Merges the PR so that the main branch is updated.

And I want that to happen all in one workflow, so that I can use https://github.com/softprops/turnstyle to prevent race conditions and merge conflicts. I'll use that subroutine in concert with https://github.com/convictional/trigger-workflow-and-wait to synchronously create a new version from any workflow that needs to do that. I'm hopeful that this will DRY up my workflows and simplify the handling of race conditions 😁

[roryabraham]

I'm unable to reproduce this test failure locally 🤔

[roryabraham]

Hmmm even after merging with the upstream, and using the local Github Actions runner, I'm still unable to reproduce this failure... 😞

Local Github Actions Run Output

in auto-approve-action on  Rory-AutoApproveAnyPullRequest is 📦 v2.1.0 roryabraham⬢ v14.16.0 
  sudo act pull_request
Password:
[CI/Lint and test] 🚀  Start image=nektos/act-environments-ubuntu:18.04
[CI/Lint and test]   🐳  docker run image=nektos/act-environments-ubuntu:18.04 entrypoint=["/usr/bin/tail" "-f" "/dev/null"] cmd=[]
[CI/Lint and test]   🐳  docker cp src=/Users/roryabraham/auto-approve-action/. dst=/github/workspace
[CI/Lint and test] ⭐  Run Check out code
[CI/Lint and test]   ✅  Success - Check out code
[CI/Lint and test] ⭐  Run Setup nodejs
[CI/Lint and test]   ☁  git clone 'https://github.com/actions/setup-node' # ref=v2
[CI/Lint and test]   🐳  docker cp src=/Users/roryabraham/.cache/act/actions-setup-node@v2 dst=/actions/
[CI/Lint and test]   💬  ::debug::isExplicit: 
[CI/Lint and test]   💬  ::debug::explicit? false
[CI/Lint and test]   💬  ::debug::evaluating 0 versions
[CI/Lint and test]   💬  ::debug::match not found
| Attempting to download 14...
[CI/Lint and test]   💬  ::debug::check 14.16.1 satisfies 14
[CI/Lint and test]   💬  ::debug::x64===x64 && darwin===linux
[CI/Lint and test]   💬  ::debug::x64===x64 && linux===linux
[CI/Lint and test]   💬  ::debug::matched 14.16.1
| Acquiring 14.16.1 - x64 from https://github.com/actions/node-versions/releases/download/14.16.1-725059535/node-14.16.1-linux-x64.tar.gz
[CI/Lint and test]   💬  ::debug::Downloading https://github.com/actions/node-versions/releases/download/14.16.1-725059535/node-14.16.1-linux-x64.tar.gz
[CI/Lint and test]   💬  ::debug::Destination /tmp/d7e45ab4-4701-4d30-8a43-1523e3696dd1
[CI/Lint and test]   💬  ::debug::download complete
| Extracting ...
[CI/Lint and test]   💬  ::debug::Checking tar --version
[CI/Lint and test]   💬  ::debug::tar (GNU tar) 1.29%0ACopyright (C) 2015 Free Software Foundation, Inc.%0ALicense GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.%0AThis is free software: you are free to change and redistribute it.%0AThere is NO WARRANTY, to the extent permitted by law.%0A%0AWritten by John Gilmore and Jay Fenlason.
| [command]/bin/tar xz --strip 1 --warning=no-unknown-keyword -C /tmp/ac083928-d8ba-4a31-b42a-94614d52a4eb -f /tmp/d7e45ab4-4701-4d30-8a43-1523e3696dd1
| Adding to the cache ...
[CI/Lint and test]   💬  ::debug::Caching tool node 14.16.1 x64
[CI/Lint and test]   💬  ::debug::source dir: /tmp/ac083928-d8ba-4a31-b42a-94614d52a4eb
[CI/Lint and test]   💬  ::debug::destination /opt/hostedtoolcache/node/14.16.1/x64
[CI/Lint and test]   💬  ::debug::finished caching tool
| Done
[CI/Lint and test]   ⚙  ::add-path:: /opt/hostedtoolcache/node/14.16.1/x64/bin
[CI/Lint and test]   ❓  ##[add-matcher]/actions/actions-setup-node@v2/.github/tsc.json
[CI/Lint and test]   ❓  ##[add-matcher]/actions/actions-setup-node@v2/.github/eslint-stylish.json
[CI/Lint and test]   ❓  ##[add-matcher]/actions/actions-setup-node@v2/.github/eslint-compact.json
[CI/Lint and test]   ✅  Success - Setup nodejs
[CI/Lint and test] ⭐  Run Install dependencies
| added 571 packages in 6.753s
[CI/Lint and test]   ✅  Success - Install dependencies
[CI/Lint and test] ⭐  Run Check style with prettier
| 
| > auto-approve-action@2.1.0 format-check /github/workspace
| > prettier --check **/*.ts
| 
| Checking formatting...
| All matched files use Prettier code style!
[CI/Lint and test]   ✅  Success - Check style with prettier
[CI/Lint and test] ⭐  Run Run tests
| 
| > auto-approve-action@2.1.0 test /github/workspace
| > jest
| 
|  PASS  src/approve.test.ts
|   ✓ when a review is successfully created (42 ms)
|   ✓ when a review is successfully created using pull-request-number (12 ms)
|   ✓ without a pull request (1 ms)
|   ✓ when the token is invalid (13 ms)
|   ✓ when the token doesn't have write permissions (12 ms)
|   ✓ when a user tries to approve their own pull request (11 ms)
|   ✓ when the token doesn't have access to the repository (9 ms)
| 
Test Suites: 1 passed, 1 total
| Tests:       7 passed, 7 total
| Snapshots:   0 total
| Time:        3.277 s
| Ran all test suites.
[CI/Lint and test]   ✅  Success - Run tests
[CI/Lint and test] ⭐  Run Check build artefact has been checked in
| 
| > auto-approve-action@2.1.0 build /github/workspace
| > ncc build src/main.ts
| 
| ncc: Version 0.27.0
| ncc: Compiling file index.js
| ncc: Using typescript@4.2.3 (local user-provided)
| 208kB  dist/index.js
| 208kB  [4041ms] - ncc 0.27.0
[CI/Lint and test]   ✅  Success - Check build artefact has been checked in

[roryabraham]

@hmarr Sorry, I'm at a bit of a loss for ideas here. Am I holding something wrong? Any ideas how I might try to reproduce this error?

[roryabraham]

FWIW, I've been using this in production for a while and it seems to work just fine 🤷

[hmarr]

Strange – I tried pushing these commits to a new branch and found the build passed successfully. I'll merge, and if the build is still broken I'll try to figure out what's going on.

[hmarr]

The tests passed after merging. 🤷 😆