feat(browser): Allow to configure popover size (ionic-team#1056)

hmaretic24 · Apr 25, 2023 · 5bdb486 · 5bdb486
1 parent 533ebbd
commit 5bdb486
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -147,6 +147,8 @@ Represents the options passed to `open`.
 | **`windowName`**        | <code>string</code>                    | Web only: Optional target for browser open. Follows the `target` property for window.open. Defaults to _blank. Ignored on other platforms. | 1.0.0 |
 | **`toolbarColor`**      | <code>string</code>                    | A hex color to which the toolbar color is set.                                                                                             | 1.0.0 |
 | **`presentationStyle`** | <code>'fullscreen' \| 'popover'</code> | iOS only: The presentation style of the browser. Defaults to fullscreen. Ignored on other platforms.                                       | 1.0.0 |
+| **`width`**             | <code>number</code>                    | iOS only: The width the browser when using presentationStyle 'popover' on iPads. Ignored on other platforms.                               | 4.0.0 |
+| **`height`**            | <code>number</code>                    | iOS only: The height the browser when using presentationStyle 'popover' on iPads. Ignored on other platforms.                              | 4.0.0 |
 
 
 #### PluginListenerHandle

diff --git a/ios/Plugin/BrowserPlugin.swift b/ios/Plugin/BrowserPlugin.swift
@@ -28,7 +28,11 @@ public class CAPBrowserPlugin: CAPPlugin {
         // display
         DispatchQueue.main.async { [weak self] in
             if style == .popover {
-                self?.setCenteredPopover(viewController)
+                if let width = call.getInt("width"), let height = call.getInt("height") {
+                    self?.setCenteredPopover(viewController, size: CGSize.init(width: width, height: height))
+                } else {
+                    self?.setCenteredPopover(viewController)
+                }
             }
             self?.bridge?.presentVC(viewController, animated: true, completion: {
                 call.resolve()

diff --git a/src/definitions.ts b/src/definitions.ts
@@ -87,6 +87,24 @@ export interface OpenOptions {
    * @since 1.0.0
    */
   presentationStyle?: 'fullscreen' | 'popover';
+
+  /**
+   * iOS only: The width the browser when using presentationStyle 'popover' on iPads.
+   *
+   * Ignored on other platforms.
+   *
+   * @since 4.0.0
+   */
+  width?: number;
+
+  /**
+   * iOS only: The height the browser when using presentationStyle 'popover' on iPads.
+   *
+   * Ignored on other platforms.
+   *
+   * @since 4.0.0
+   */
+  height?: number;
 }
 
 /**