This repository has been archived by the owner on Oct 3, 2020. It is now read-only.
Improve user-friendliness of object_factory #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows annotation-aware editors like PyCharm to offer relevant code completion like filter and get_*.
My KUBECONFIG env variable is set to something different, so this test fails because it compares a hardcoded path to the user's environment.
|
@hjacobs What do you think? |
|
Sorry I overlooked this PR, LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25.
object_factorywith akindthat does not exist in the cluster.object_factoryso that smart editors (e.g. PyCharm) are still able to autocomplete on the generated types.test_from_default_kubeconfigso that it takes theKUBECONFIGenv variable into account. Otherwise, the test was failing locally on my machine becauseKUBECONFIGis defined and points to something else than~/.kube/config.