Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support effective tokens calculation on sft/dpo #6078

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

wtmlon
Copy link
Contributor

@wtmlon wtmlon commented Nov 19, 2024

What does this PR do?

support efficient tokens calculation on sft and dpo.

@wtmlon wtmlon changed the title support efficient tokens calculation on sft/dpo support effective tokens calculation on sft/dpo Nov 19, 2024
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature, please see the above comments

src/llamafactory/train/dpo/workflow.py Outdated Show resolved Hide resolved
src/llamafactory/train/dpo/workflow.py Show resolved Hide resolved
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants