Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass -1 to Mqtt5PublishBuilderBase.messageExpiryInterval to disable message expiry #604

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Allow to pass -1 to Mqtt5PublishBuilderBase.messageExpiryInterval to disable message expiry #604

merged 1 commit into from
Nov 14, 2023

Conversation

SgtSilvio
Copy link
Member

@SgtSilvio SgtSilvio self-assigned this Nov 14, 2023
@cla-bot cla-bot bot added the cla-signed label Nov 14, 2023
pglombardo
pglombardo approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@pglombardo pglombardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add this ability to C# as well.

@SgtSilvio SgtSilvio force-pushed the improvement/no-message-expiry branch from d32ca9e to cd2da84 Compare November 14, 2023 12:22
@SgtSilvio SgtSilvio merged commit bb5dee5 into master Nov 14, 2023
2 checks passed
@SgtSilvio SgtSilvio deleted the improvement/no-message-expiry branch November 14, 2023 12:32
@hcrgm hcrgm mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasBrand LukasBrand LukasBrand approved these changes

@pglombardo pglombardo pglombardo approved these changes

Assignees

@SgtSilvio SgtSilvio

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to set message expiry interval with MqttPublish.NO_MESSAGE_EXPIRY due to invalid assert
3 participants
@SgtSilvio @pglombardo @LukasBrand