Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom http headers to MqttWebSocket #500

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

hctemmel
Copy link
Contributor

Motivation
Added the option to add custom http headers (eg bearer token authentication to reverse proxy) for websocket connection

Changes
MqttWebSocketConfig

@hctemmel hctemmel requested a review from SgtSilvio as a code owner August 16, 2021 13:22
@cla-bot
Copy link

cla-bot bot commented Aug 16, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@SgtSilvio
Copy link
Member

@hctemmel Thank you for your contribution.
It seems to be pretty good, but before we can review and incorporate it, you need to sign our CLA.
Please follow the instruction of the cla-bot's comment. If something is unclear please just ask.

@cla-bot
Copy link

cla-bot bot commented Aug 25, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@cla-bot
Copy link

cla-bot bot commented Dec 21, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel, @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@skrutzler
Copy link
Contributor

It took a while but the CLA is now signed and was sent to contributing@hivemq.com

@skrutzler
Copy link
Contributor

Hello @SgtSilvio. Do you need anything else from my side to start the review process?
Thanks a lot and best regards.

@SgtSilvio
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 4, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel, @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@cla-bot
Copy link

cla-bot bot commented Jan 4, 2022

The cla-bot has been summoned, and re-checked this pull request!

@SgtSilvio
Copy link
Member

Sorry, please ignore the above messages from the cla-bot, I need to check who has access to contributing@hivemq.com

@MagiErber
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 4, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@cla-bot
Copy link

cla-bot bot commented Jan 4, 2022

The cla-bot has been summoned, and re-checked this pull request!

@MagiErber
Copy link
Member

Hi @skrutzler, thank you for your contribution! Unfortunately the GitHub username (skrutzler) is not part of the list. Can you please send us an updated signed CLA with this username on the list as well? Thank you!

@skrutzler
Copy link
Contributor

skrutzler commented Jan 4, 2022

Hi @skrutzler, thank you for your contribution! Unfortunately the GitHub username (skrutzler) is not part of the list. Can you please send us an updated signed CLA with this username on the list as well? Thank you!

Hello. My username (preto) was on the signed CLA. skrutzler is just the changed nickname and belongs to the same registered user ( click on my profile to see it ;) @skrutzler )
I guess it would take me another 3 months with my employee legal department to get an updated document ...

@SgtSilvio
Copy link
Member

@skrutzler I am very sorry for the delay.
The easiest way would be to remove your commit, as it is an empty merge commit anyhow. Rebasing your branch on master should remove this commit. I can also help to do that once I find the time for it.
Unfortunately we can not add preto to the CLA list, as this is actually your nickname and skrutzler is your username/profile on GitHub.

@skrutzler
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Dec 20, 2022
@cla-bot
Copy link

cla-bot bot commented Dec 20, 2022

The cla-bot has been summoned, and re-checked this pull request!

@skrutzler
Copy link
Contributor

@SgtSilvio I think all requirements are met now and it can be merged if there are not any remarks.

Do you know by any chance when a new release with those changes might be triggered?

@skrutzler
Copy link
Contributor

is there anything still missing on our end @SgtSilvio ?

@pglombardo
Copy link
Contributor

Hi @skrutzler - thanks for staying on top of this and traversing the cla bot. Either I or @SgtSilvio will take a look at this very soon and post an update.

@pglombardo pglombardo merged commit d709dc3 into hivemq:master Feb 15, 2023
@pglombardo
Copy link
Contributor

Thanks for your work and patience on this @skrutzler! PR is merged. We'll put out a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants