-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom http headers to MqttWebSocket #500
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
@hctemmel Thank you for your contribution. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel, @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
It took a while but the CLA is now signed and was sent to contributing@hivemq.com |
Hello @SgtSilvio. Do you need anything else from my side to start the review process? |
@cla-bot check |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel, @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
The cla-bot has been summoned, and re-checked this pull request! |
Sorry, please ignore the above messages from the cla-bot, I need to check who has access to contributing@hivemq.com |
@cla-bot check |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
The cla-bot has been summoned, and re-checked this pull request! |
Hi @skrutzler, thank you for your contribution! Unfortunately the GitHub username (skrutzler) is not part of the list. Can you please send us an updated signed CLA with this username on the list as well? Thank you! |
Hello. My username (preto) was on the signed CLA. skrutzler is just the changed nickname and belongs to the same registered user ( click on my profile to see it ;) @skrutzler ) |
@skrutzler I am very sorry for the delay. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@SgtSilvio I think all requirements are met now and it can be merged if there are not any remarks. Do you know by any chance when a new release with those changes might be triggered? |
is there anything still missing on our end @SgtSilvio ? |
Hi @skrutzler - thanks for staying on top of this and traversing the cla bot. Either I or @SgtSilvio will take a look at this very soon and post an update. |
Thanks for your work and patience on this @skrutzler! PR is merged. We'll put out a new release soon. |
Motivation
Added the option to add custom http headers (eg bearer token authentication to reverse proxy) for websocket connection
Changes
MqttWebSocketConfig