Feature/manual ack #403
Merged
Feature/manual ack #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sauroter
reviewed
Apr 16, 2020
sauroter
reviewed
Apr 16, 2020
src/main/java/com/hivemq/client/mqtt/mqtt5/message/publish/Mqtt5Publish.java
Show resolved
Hide resolved
sauroter
reviewed
Apr 16, 2020
src/main/java/com/hivemq/client/mqtt/mqtt5/message/auth/Mqtt5AuthBuilder.java
Show resolved
Hide resolved
sauroter
reviewed
Apr 16, 2020
src/main/java/com/hivemq/client/mqtt/mqtt5/message/publish/Mqtt5Publish.java
Show resolved
Hide resolved
sauroter
reviewed
Apr 16, 2020
reactor/src/main/java/com/hivemq/client/mqtt/mqtt5/reactor/Mqtt5ReactorClient.java
Show resolved
Hide resolved
|
I think this works as intended. |
sauroter
approved these changes
Apr 16, 2020
SgtSilvio
force-pushed
the
feature/automatic-resubscribe
branch
from
7b7a86e to
828edad
Compare
SgtSilvio
force-pushed
the
feature/manual-ack
branch
from
8a5e4fe to
afc6d73
Compare
Merged
SgtSilvio
force-pushed
the
feature/manual-ack
branch
2 times, most recently
from
f8c3a9e to
4f8bfd5
Compare
SgtSilvio
changed the base branch from
feature/automatic-resubscribe
to
develop
…ibe and publishes methods
Added CheckReturnValue annotations to Mqtt3/ReactorClient
…roperty of Subscribe message
…th) that returns a builder to also specify manual ack
SgtSilvio
force-pushed
the
feature/manual-ack
branch
from
4f8bfd5 to
c2df96c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #304
IMPORTANT: base branch needs to be changed to develop once #398 is merged.
Changes
Mqtt3/5Rx/Async/Blocking/ReactorClient.publishesMqtt3/5RxClient.subscribePublishes(With)andMqtt3/5AsyncClient.subscribe(With)Mqtt3/5RxClient.subscribeStream(With), replaced withsubscribePublishes(With)Mqtt3/5Publish.acknowledge