Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing event loop when connection failed and not reconnecting #356

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

SgtSilvio
Copy link
Member

@SgtSilvio SgtSilvio commented Dec 15, 2019

Motivation
Automatic thread management must work in any error case.
Currently the event loop is not released in an edge case when the host name is not found and reconnect is not enabled.

Changes

  • Release client event loop on all connection failures

@cla-bot cla-bot bot added the cla-signed label Dec 15, 2019
@SgtSilvio SgtSilvio self-assigned this Dec 15, 2019
@SgtSilvio SgtSilvio added the bug label Dec 15, 2019
@SgtSilvio SgtSilvio added this to the 1.2 milestone Dec 15, 2019
@SgtSilvio SgtSilvio force-pushed the bugfix/release-event-loop-connection-failed branch from 830b33a to 5275e03 Compare January 17, 2020 11:35
@SgtSilvio SgtSilvio requested a review from gitseti January 22, 2020 13:07
@SgtSilvio SgtSilvio force-pushed the bugfix/release-event-loop-connection-failed branch from 5275e03 to b64bee6 Compare February 5, 2020 07:36
@SgtSilvio SgtSilvio merged commit d99758e into develop Feb 14, 2020
@SgtSilvio SgtSilvio deleted the bugfix/release-event-loop-connection-failed branch February 14, 2020 11:37
@SgtSilvio SgtSilvio modified the milestones: 1.2, 1.1.4 Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants