Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples/request response #337

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Examples/request response #337

merged 3 commits into from
Oct 25, 2019

Conversation

SgtSilvio
Copy link
Member

Motivation
Show how to use the request/response feature of MQTT 5.

Changes

  • Added request/response example
  • Fixed small inconsistencies in toString methods

@SgtSilvio SgtSilvio requested a review from gitseti October 17, 2019 13:49
@SgtSilvio SgtSilvio self-assigned this Oct 17, 2019
@cla-bot cla-bot bot added the cla-signed label Oct 17, 2019
@SgtSilvio SgtSilvio added this to the 1.1.3 milestone Oct 18, 2019
gitseti
gitseti approved these changes Oct 23, 2019
View reviewed changes
Copy link

@gitseti gitseti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean example! 👍
I only made some minor suggestions for variable naming and commenting.

examples/src/main/java/com/hivemq/client/mqtt/examples/RequestResponse.java Show resolved Hide resolved
examples/src/main/java/com/hivemq/client/mqtt/examples/RequestResponse.java Outdated Show resolved Hide resolved
examples/src/main/java/com/hivemq/client/mqtt/examples/RequestResponse.java Outdated Show resolved Hide resolved
examples/src/main/java/com/hivemq/client/mqtt/examples/RequestResponse.java Outdated Show resolved Hide resolved
@SgtSilvio SgtSilvio merged commit 3a49f4e into develop Oct 25, 2019
@SgtSilvio SgtSilvio deleted the examples/request-response branch October 25, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitseti gitseti gitseti approved these changes

Assignees

@SgtSilvio SgtSilvio

Labels
cla-signed improvement
Projects
None yet
Milestone
1.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtSilvio @gitseti