refactor(25464): Improver visual identity of the workspace #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
force-pushed
the
epic/23777/bi-directional-frontend
branch
from
7ef1fa9
to
d7026fe
Compare
vanch3d
force-pushed
the
refactor/25464/workspace-visual-identity
branch
from
ea874e4
to
d59bbf6
Compare
oli-hivemq
reviewed
Sep 10, 2024
hivemq-edge/src/frontend/src/modules/Workspace/components/nodes/NodeDevice.tsx
Outdated
Show resolved
Hide resolved
oli-hivemq
approved these changes
Sep 10, 2024
- remove attribution
vanch3d
force-pushed
the
refactor/25464/workspace-visual-identity
branch
from
6528c60
to
70bc502
Compare
vanch3d
merged commit 2d7158f
into
epic/23777/bi-directional-frontend
8 of 9 checks passed
vanch3d
added a commit
that referenced
this pull request
Sep 11, 2024
refactor(25464): Improver visual identity of the workspace * refactor(25464): export visual mapping for adapter status * refactor(25464): export zoom selectors * refactor(25464): add glue to adapter and bridge nodes * refactor(25464): add style to the minimap * refactor(25464): change icon * refactor(25464): refactor nodes to introduce skeleton rendering * refactor(25464): hide toolbars when nodes are being dragged * refactor(25464): add devices to the group when adapters are added * test(25464): fix tests * fix(25464): change theme to match data hub reactflow * refactor(25464): refactor the toolbar button group for reuse * test(25464): add tests * fix(25464): fix edge markers * test(25464): fix tests * fix(25464): fix review issues
vanch3d
added a commit
that referenced
this pull request
Sep 23, 2024
refactor(25464): Improver visual identity of the workspace * refactor(25464): export visual mapping for adapter status * refactor(25464): export zoom selectors * refactor(25464): add glue to adapter and bridge nodes * refactor(25464): add style to the minimap * refactor(25464): change icon * refactor(25464): refactor nodes to introduce skeleton rendering * refactor(25464): hide toolbars when nodes are being dragged * refactor(25464): add devices to the group when adapters are added * test(25464): fix tests * fix(25464): change theme to match data hub reactflow * refactor(25464): refactor the toolbar button group for reuse * test(25464): add tests * fix(25464): fix edge markers * test(25464): fix tests * fix(25464): fix review issues
vanch3d
added a commit
that referenced
this pull request
Sep 27, 2024
refactor(25464): Improver visual identity of the workspace * refactor(25464): export visual mapping for adapter status * refactor(25464): export zoom selectors * refactor(25464): add glue to adapter and bridge nodes * refactor(25464): add style to the minimap * refactor(25464): change icon * refactor(25464): refactor nodes to introduce skeleton rendering * refactor(25464): hide toolbars when nodes are being dragged * refactor(25464): add devices to the group when adapters are added * test(25464): fix tests * fix(25464): change theme to match data hub reactflow * refactor(25464): refactor the toolbar button group for reuse * test(25464): add tests * fix(25464): fix edge markers * test(25464): fix tests * fix(25464): fix review issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/25464/details/
This PR is part of the bi-directional epic and improves the rendering and interactions of the workspace
devicenodes are now "glued" to theiradapter, any change in one location results in a similar move to the other.hostnodes are similarly "glued" to thebridgenodesadaptersare added to a group, theirdeviceis also addedData HubandWorkspaceOut-of-scope
workspacecould be changed to a different paradigm (e.g. north/south). It will be done in a different ticket, see https://hivemq.kanbanize.com/ctrl_board/57/cards/25337/details/Before
After