Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(25160): Add devices and brokers to the workspace #526

Merged
merged 11 commits into from
Aug 15, 2024
Merged

feat(25160): Add devices and brokers to the workspace #526

merged 11 commits into from
Aug 15, 2024

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Aug 14, 2024 •
edited
Loading

See https://hivemq.kanbanize.com/ctrl_board/57/cards/25160/details/

The PR contributes to the bi-directionality epics by adding devices (as the entity connected to Edge by the adapter) and brokers (as the entity connected to the Edge by a bridge).

The connectivity on the workspace and the interactions follow the same principles as for the bridges and adapters:

  • devices are only added for protocols that support the WRITE capability
  • devices are connected "outwardly" from the adapter, materialising the "outbound" connection
  • the colour of the link reflects the status of the adapter
  • the animated status of the link reflects the existence of a working "outbound" subscription
  • devices can be selected and dragged around independently from their adapter
  • devices cannot be double-clicked to open a side-panel
  • devices are represented differently from the other nodes on the workspace, displaying the category of the protocol, its name and the capabilities

Out-of-scope

  • Icons for the protocol category are not based on the payload received with all protocol specs. It will be addressed in a separate ticket.
  • The WRITE capability is not defined yet and will be mocked until addressed in a subsequent ticket

Before

screenshot-localhost_3000-2024 08 14-14_14_43

After

screenshot-localhost_3000-2024 08 14-14_06_42

@vanch3d vanch3d requested review from h2xd and sfrehse August 14, 2024 13:25
@vanch3d vanch3d self-assigned this Aug 14, 2024
@cla-bot cla-bot bot added the cla-signed label Aug 14, 2024
@vanch3d vanch3d marked this pull request as ready for review August 14, 2024 13:59
@vanch3d vanch3d changed the base branch from master to epic/23777/bi-directional-frontend August 14, 2024 14:00
@vanch3d vanch3d force-pushed the epic/23777/bi-directional-frontend branch from d57f645 to 9869533 Compare August 14, 2024 20:02
@vanch3d vanch3d force-pushed the feat/25160/workspace-devices branch from bf74dc1 to 8ed270e Compare August 14, 2024 20:03
h2xd
h2xd approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@h2xd h2xd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐊

hivemq-edge/src/frontend/src/modules/Workspace/components/nodes/NodeAdapter.tsx Show resolved Hide resolved
hivemq-edge/src/frontend/src/modules/Workspace/utils/adapter.utils.ts Outdated Show resolved Hide resolved
@vanch3d vanch3d force-pushed the feat/25160/workspace-devices branch from 075ecef to 0f4abd7 Compare August 15, 2024 15:03
@vanch3d vanch3d merged commit a68451f into epic/23777/bi-directional-frontend Aug 15, 2024
8 of 9 checks passed
@vanch3d vanch3d deleted the feat/25160/workspace-devices branch August 15, 2024 15:14
vanch3d added a commit that referenced this pull request Aug 26, 2024
@vanch3d
Merge pull request #526
dd4ce2c 
feat(25160): Add devices and brokers to the workspace

* feat(25160): add mock for bi-directional

* feat(25160): add type for DEVICE node

* feat(25160): add custom node for DEVICE

* refactor(25160): remove the show host option

* refactor(25160): add device-related handle to adapter

* feat(25160): add device node and link to adapter to the workspace

* test(25160): add tests

* test(25160): fix tests

* test(25160): add tests

* test(25160): fix tests and rename the file

* refactor(25160): updated type
@vanch3d vanch3d mentioned this pull request Aug 29, 2024
Draft
vanch3d added a commit that referenced this pull request Sep 3, 2024
@vanch3d
Merge pull request #526
5c175a5 
feat(25160): Add devices and brokers to the workspace

* feat(25160): add mock for bi-directional

* feat(25160): add type for DEVICE node

* feat(25160): add custom node for DEVICE

* refactor(25160): remove the show host option

* refactor(25160): add device-related handle to adapter

* feat(25160): add device node and link to adapter to the workspace

* test(25160): add tests

* test(25160): fix tests

* test(25160): add tests

* test(25160): fix tests and rename the file

* refactor(25160): updated type
vanch3d added a commit that referenced this pull request Sep 5, 2024
@vanch3d
Merge pull request #526
50e4078 
feat(25160): Add devices and brokers to the workspace

* feat(25160): add mock for bi-directional

* feat(25160): add type for DEVICE node

* feat(25160): add custom node for DEVICE

* refactor(25160): remove the show host option

* refactor(25160): add device-related handle to adapter

* feat(25160): add device node and link to adapter to the workspace

* test(25160): add tests

* test(25160): fix tests

* test(25160): add tests

* test(25160): fix tests and rename the file

* refactor(25160): updated type
vanch3d added a commit that referenced this pull request Sep 10, 2024
@vanch3d
Merge pull request #526
3598f53 
feat(25160): Add devices and brokers to the workspace

* feat(25160): add mock for bi-directional

* feat(25160): add type for DEVICE node

* feat(25160): add custom node for DEVICE

* refactor(25160): remove the show host option

* refactor(25160): add device-related handle to adapter

* feat(25160): add device node and link to adapter to the workspace

* test(25160): add tests

* test(25160): fix tests

* test(25160): add tests

* test(25160): fix tests and rename the file

* refactor(25160): updated type
vanch3d added a commit that referenced this pull request Sep 11, 2024
@vanch3d
Merge pull request #526
cebdd8b 
feat(25160): Add devices and brokers to the workspace

* feat(25160): add mock for bi-directional

* feat(25160): add type for DEVICE node

* feat(25160): add custom node for DEVICE

* refactor(25160): remove the show host option

* refactor(25160): add device-related handle to adapter

* feat(25160): add device node and link to adapter to the workspace

* test(25160): add tests

* test(25160): fix tests

* test(25160): add tests

* test(25160): fix tests and rename the file

* refactor(25160): updated type
vanch3d added a commit that referenced this pull request Sep 23, 2024
@vanch3d
Merge pull request #526
1ffc453 
feat(25160): Add devices and brokers to the workspace

* feat(25160): add mock for bi-directional

* feat(25160): add type for DEVICE node

* feat(25160): add custom node for DEVICE

* refactor(25160): remove the show host option

* refactor(25160): add device-related handle to adapter

* feat(25160): add device node and link to adapter to the workspace

* test(25160): add tests

* test(25160): fix tests

* test(25160): add tests

* test(25160): fix tests and rename the file

* refactor(25160): updated type
vanch3d added a commit that referenced this pull request Sep 27, 2024
@vanch3d
Merge pull request #526
611dc39 
feat(25160): Add devices and brokers to the workspace

* feat(25160): add mock for bi-directional

* feat(25160): add type for DEVICE node

* feat(25160): add custom node for DEVICE

* refactor(25160): remove the show host option

* refactor(25160): add device-related handle to adapter

* feat(25160): add device node and link to adapter to the workspace

* test(25160): add tests

* test(25160): fix tests

* test(25160): add tests

* test(25160): fix tests and rename the file

* refactor(25160): updated type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h2xd h2xd h2xd approved these changes

@sfrehse sfrehse Awaiting requested review from sfrehse

Assignees

@vanch3d vanch3d

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanch3d @h2xd