-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(18350): Refactor the theme structure #254
Merged
simon622
merged 16 commits into
fix/18349/accessibility
from
refactor/18350/theme-structure
Jan 5, 2024
Merged
refactor(18350): Refactor the theme structure #254
simon622
merged 16 commits into
fix/18349/accessibility
from
refactor/18350/theme-structure
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
changed the title
refactor(18350): Refactor the theme strcture
refactor(18350): Refactor the theme structure
Dec 20, 2023
feat(18382): Add tooltip to the relevant icon buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/18350/details/
This PR is mostly a refactoring of the internal theme defined for
Edge
, in order to make it ready for integration with the design system we are building for theHiveMQ
ecosystemIt restructures the theme's file system, to allow better flexibility and automation (e.g. change by pull requests).
It also refactors a few component to ensure consistency in the design and styling of their instances across the application, following these principles:
variants
of the base component, modifiable though a single source of truth (the theme)primary
variant)Notes:
props
rather thanstyle
and these properties are not available through theming