Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(18350): Refactor the theme structure #254

Merged
merged 16 commits into from
Jan 5, 2024

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Dec 20, 2023

See https://hivemq.kanbanize.com/ctrl_board/57/cards/18350/details/

This PR is mostly a refactoring of the internal theme defined for Edge, in order to make it ready for integration with the design system we are building for the HiveMQ ecosystem

It restructures the theme's file system, to allow better flexibility and automation (e.g. change by pull requests).

It also refactors a few component to ensure consistency in the design and styling of their instances across the application, following these principles:

  • styling should be primarily through variants of the base component, modifiable though a single source of truth (the theme)
  • all instances of the same component should be styled exactly the same (e.g. all main CTA buttons using the primary variant)

Notes:

  • There will be components that are not abidning to the principles above. They will be corrected as soon as work is needed on them, on the basis of this enabling PR.
  • There are limitations in the alignment of components. Many of them are customised by props rather than style and these properties are not available through theming

@cla-bot cla-bot bot added the cla-signed label Dec 20, 2023
@vanch3d vanch3d marked this pull request as ready for review December 20, 2023 13:19
@vanch3d vanch3d changed the title refactor(18350): Refactor the theme strcture refactor(18350): Refactor the theme structure Dec 20, 2023
@vanch3d vanch3d self-assigned this Dec 20, 2023
@simon622 simon622 merged commit 76a98c8 into fix/18349/accessibility Jan 5, 2024
5 checks passed
@simon622 simon622 deleted the refactor/18350/theme-structure branch January 5, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants