Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 fix duplicate machine tags. #91

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

guettli
Copy link
Collaborator

@guettli guettli commented Jun 28, 2023

What type of PR is this?

/kind bug Fixes a newly discovered bug.

What this PR does / why we need it:

Tags on HV machines are sometime duplicate.

{
  "deviceId": 15337,
 ...
 "tags": [
    "caphv-device-type=hvWorker",
    "caphv-cluster-name=hvtest-guettli",
    "caphv-cluster-hvtest-guettli=owned",
    "caphv-machine-name=hvtest-guettli-md-0-5pr2l",
    "caphv-cluster-name=hvtest-guettli",
    "caphv-machine-name=hvtest-guettli-md-0-5pr2l",
    "caphv-cluster-name=worker"
  ]
}

duplicate: caphv-cluster-name=hvtest-guettli caphv-machine-name=hvtest-guettli-md-0-5pr2l

And: caphv-cluster-name=worker looks strange.

Fixes #70

@guettli guettli requested a review from janiskemper June 28, 2023 12:52
@guettli guettli force-pushed the tg/fix-duplicate-machine-tags branch from 40d6ca3 to 5d4b4e4 Compare June 29, 2023 08:11
@guettli guettli merged commit 2872423 into main Jun 29, 2023
@guettli guettli deleted the tg/fix-duplicate-machine-tags branch June 29, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate machine Tags.
2 participants