✨ Auto-detect permanent-error #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guettli
force-pushed
the
verify-shutdown
branch
from
acbd8f4 to
96bd24a
Compare
janiskemper
commented
Oct 23, 2023
guettli
force-pushed
the
verify-shutdown
branch
from
eb71548 to
7de6a76
Compare
janiskemper
commented
Oct 27, 2023
We talked about how to detect if a machine was successfully deprovisioned. We had the idea to create a simple tcpserver which the controller could check. I found a simpler solution. If the machine is on and not reloading and Script does not contain "cloud-init", then the machine is provisioned with the dummy-machine-image. Since we don't make network connections to the machine up to now, I would rather not create the dummy tcpserver., |
guettli
force-pushed
the
verify-shutdown
branch
from
3d4ee8b to
b161da0
Compare
guettli
force-pushed
the
verify-shutdown
branch
2 times, most recently
from
8793e7d to
51771af
Compare
Adding state to verify that a device is shut down. Also deal with a state where the device is reloading forever. Set a label on that device that it is unhealthy and should not be used in that case.
guettli
force-pushed
the
verify-shutdown
branch
from
51771af to
acc3ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding state to verify that a device is shut down. Also deal with a state where the device is reloading forever. Set a label on that device that it is unhealthy and should not be used in that case.